Introduce `ActionRunAttempt` to represent each execution of a run by Zettat123 · Pull Request #37119 · go-gitea/gitea

Zettat123 · 2026-04-06T00:42:47Z

This PR introduces a new ActionRunAttempt model and makes Actions execution attempt-scoped.

Main Changes

Each workflow run trigger generates a new ActionRunAttempt. The triggered jobs are then associated with this new ActionRunAttempt record.
Each rerun now creates:
- a new ActionRunAttempt record for the workflow run
- a full new set of ActionRunJob records for the new ActionRunAttempt
  - For jobs that need to be rerun, the new job records are created as runnable jobs in the new attempt.
  - For jobs that do not need to be rerun, new job records are still created in the new attempt, but they reuse the result of the previous attempt instead of executing again.
Introduce rerunPlan to manage each rerun and refactored rerun flow into a two-phase plan-based model:
- buildRerunPlan
- execRerunPlan
Converted artifacts from run-scoped to attempt-scoped:
- uploads are now associated with RunAttemptID
- listing, download, and deletion resolve against the current attempt
Added attempt-aware web Actions views:
- the default run page shows the latest attempt (/actions/runs/{run_id})
- previous attempt pages show jobs and artifacts for that attempt (/actions/runs/{run_id}/attempts/{attempt_num})
New APIs:
- /repos/{owner}/{repo}/actions/runs/{run}/attempts/{attempt}
- /repos/{owner}/{repo}/actions/runs/{run}/attempts/{attempt}/jobs

Compatibility

Existing legacy runs use LatestAttemptID = 0 and legacy jobs use RunAttemptID = 0. Therefore, these fields can be used to identify legacy runs and jobs and provide backward compatibility.
Existing artifact records are not backfilled; legacy artifacts continue to use RunAttemptID = 0.

Improvements

It is now easier to inspect and download logs from previous attempts.
run_attempt semantics are now aligned with GitHub.
- A unique number for each attempt of a particular workflow run in a repository. This number begins at 1 for the workflow run's first attempt, and increments with each re-run.
Rerun behavior is now clearer and more explicit.
- Instead of mutating the status of previous jobs in place, each rerun creates a new attempt with a full new set of job records.
Artifacts produced by different reruns can now be listed separately.

TODO

Screenshots

Run with only one attempt:

Rerunning:

Latest attempt:

Previous attempt (rerun is not allowed):

Dropdown for attempt records:

services/actions/job_emitter.go

services/actions/context.go

services/actions/job_emitter.go

bircni · 2026-04-06T07:54:34Z

services/actions/run.go

+			return err
+		}
+
+		run.LatestAttemptID = runAttempt.ID


UpdateRunAttempt calls UpdateRun again to sync status/started/stopped. That's three writes to action_run inside one transaction.

Yes, I’ve noticed that issue as well. In this function, we need to create/update the same ActionRun record three times.

Create the ActionRun to get ActionRun.ID

Use ActionRun.ID to create a RunAttempt and write RunAttempt.ID back to ActionRun.LatestAttemptID

After all the jobs are created, update ActionRun.Status (via UpdateRunAttempt)

I'm not sure of a better way to handle this yet - any ideas are welcome.

routers/web/repo/actions/view.go

models/actions/run_attempt.go

templates/repo/actions/view_component.tmpl

silverwind · 2026-04-07T20:24:35Z

Would order buttons like [attempt] [re-run all]. People are use to buttons being at the same places.
Hide the button on first attempt, only show on subsequent ones (maybe that's already the case).

silverwind · 2026-04-07T20:26:40Z

Two concerns worth addressing:

1. Race condition on concurrent reruns

Two simultaneous rerun requests for the same run both read templateAttempt.Attempt and try to insert an attempt with Attempt = templateAttempt.Attempt + 1. The UNIQUE(run_attempt) constraint catches this at the DB level, but the error surfaces as an internal server error rather than a clean user-facing message. A retry or ErrAlreadyExists check in execRerunPlan would be a small fix with real UX impact.

2. RecreateTables on action_artifact in migration v331

base.RecreateTables(new(actionArtifact)) copies the entire table to change the unique index from runid_name_path to runid_attempt_name_path. On large instances this locks the table for the duration of a full data copy. If the only goal is renaming the unique index and adding the run_attempt_id column, a lighter migration (add column, drop old index, create new index) would be much safer in production.

This comment was written by Claude Opus 4.6.

web_src/js/components/RepoActionView.vue

silverwind · 2026-04-07T20:35:29Z

A few inconsistencies with GitHub's behavior:

1. actor vs triggering_actor semantics

On GitHub, actor is the person who originally triggered the workflow and stays constant across all attempts. triggering_actor is the person who initiated each specific attempt and changes on rerun. In this PR, ToActionWorkflowRun sets both fields to the attempt's trigger user.

Example from GitHub (cli/cli run 23574913305):

Attempt 1: actor=mateenali66, triggering_actor=mateenali66
Attempt 2: actor=mateenali66, triggering_actor=williammartin

The actor should remain run.TriggerUser regardless of which attempt is being viewed.

2. Missing previous_attempt_url field

GitHub's workflow run response includes previous_attempt_url which links to the API endpoint of the prior attempt (e.g. .../runs/123/attempts/1 for attempt 2, null for attempt 1). This field is absent from Gitea's ActionWorkflowRun struct.

3. Attempt switcher label differs from GitHub

On GitHub, the dropdown button shows just Latest when viewing the latest attempt. The PR currently shows Latest attempt #N. The dropdown items should show Attempt #N for all entries. Only the button text for the current latest should be just Latest.

This comment was written by Claude Opus 4.6.

Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: Zettat123 <zettat123@gmail.com>

wxiaoguang · 2026-04-08T01:05:29Z

/devtest/repo-action-view can also be updated, then more edge cases can be easily tested without really setting up an Actions run.

Zettat123 · 2026-04-08T03:10:25Z

Would order buttons like [attempt] [re-run all]. People are use to buttons being at the same places.

Hide the button on first attempt, only show on subsequent ones (maybe that's already the case).

Attempt switcher label differs from GitHub

Fixed by 7c8e2a8. Please see the latest screenshots in description.

Race condition on concurrent reruns

9dafc83

RecreateTables on action_artifact in migration v331

d1d6b5c

actor vs triggering_actor semantics

8c5c5b9

Missing previous_attempt_url field

3d488fb

Zettat123 · 2026-04-08T03:11:00Z

/devtest/repo-action-view can also be updated, then more edge cases can be easily tested without really setting up an Actions run.

Updated /devtest/repo-action-view in f354e00

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2026

github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/migrations modifies/frontend labels Apr 6, 2026

Zettat123 added the topic/gitea-actions related to the actions of Gitea label Apr 6, 2026

Zettat123 force-pushed the run-attempt branch 2 times, most recently from 3da69e5 to 7f338dd Compare April 6, 2026 05:11

add run_attempt

2f5cdb9

Zettat123 force-pushed the run-attempt branch from 7f338dd to 2f5cdb9 Compare April 6, 2026 05:59

Zettat123 mentioned this pull request Apr 6, 2026

actions: expose previous job attempts and allow downloading attempt logs #37052

Draft

bircni self-requested a review April 6, 2026 07:36

bircni reviewed Apr 6, 2026

View reviewed changes

Zettat123 added 8 commits April 6, 2026 15:09

fix check concurrency bug

d83ec3a

fix find needs

cc7ca30

fix parse 'attempt'

19c82f9

remove unused field

8b79334

remove GetLatestAttemptByRunID

e38cb32

fix tabs

5f188ca

fix

eb294a3

fix models

4fe29a1

Zettat123 changed the title ~~Introduce RunAttempt to represent each execution of a run~~ Introduce ActionRunAttempt to represent each execution of a run Apr 6, 2026

Zettat123 added 7 commits April 6, 2026 16:15

fix model bugs

738728d

fix api

6918e8c

fix api

7d572e5

fix test

4c8b561

fix concurrency/rerun test

5d4a2c9

Merge branch 'main' into run-attempt

0f50150

fix calculateDuration

20608e3

Zettat123 added 7 commits April 6, 2026 22:08

fix rerun test

6883819

improve rerun/actions log test

735c41b

API support

52c4e28

update swagger

870b17f

fix test

674348a

fix lint

f8c9a0e

fix rerun

35bba9a

Zettat123 mentioned this pull request Apr 7, 2026

WIP: Improve support for reusable workflows #36388

Draft

8 tasks

fix lint

a7f8076

silverwind reviewed Apr 7, 2026

View reviewed changes

web_src/js/components/RepoActionView.vue Outdated Show resolved Hide resolved

Zettat123 and others added 5 commits April 7, 2026 15:05

test run attempt for artifact v3

51dfc2c

Update web_src/js/components/RepoActionView.vue

bb65c5c

Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: Zettat123 <zettat123@gmail.com>

improve ui

7c8e2a8

refactor actions notify

8c5c5b9

improve ui

865b0c3

Zettat123 added 5 commits April 7, 2026 19:21

fix attempt race condition

9dafc83

fix migration

d1d6b5c

add previous_attempt_url

3d488fb

update swagger

9b47da3

update devtest

f354e00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce `ActionRunAttempt` to represent each execution of a run#37119

Introduce `ActionRunAttempt` to represent each execution of a run#37119
Zettat123 wants to merge 34 commits intogo-gitea:mainfrom
Zettat123:run-attempt

Zettat123 commented Apr 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bircni Apr 6, 2026

Uh oh!

Zettat123 Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 7, 2026 •

edited

Loading

Uh oh!

silverwind commented Apr 7, 2026

Uh oh!

Uh oh!

silverwind commented Apr 7, 2026 •

edited

Loading

Uh oh!

wxiaoguang commented Apr 8, 2026

Uh oh!

Zettat123 commented Apr 8, 2026

Uh oh!

Zettat123 commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Zettat123 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bircni Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Zettat123 Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 7, 2026

Uh oh!

Uh oh!

silverwind commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 8, 2026

Uh oh!

Zettat123 commented Apr 8, 2026

Uh oh!

Zettat123 commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zettat123 commented Apr 6, 2026 •

edited

Loading

silverwind commented Apr 7, 2026 •

edited

Loading

silverwind commented Apr 7, 2026 •

edited

Loading